Smack  Check-in [6c59a1592a]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix /click requiring to be specified "LeftButton" once again on the PTR (whereas it doesn't want that param at all on the beta right now), jfc blizzard make up your mind it's the other way around every other build (taking the bet that whatever gets pushed to the live servers tomorrow will behave like the PTR right now)
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 6c59a1592a910db29c05353a3af0d54d642b61aa75e960b128cb4dfafab73ed0
User & Date: zlodo 2022-10-25 01:10:32
Context
2022-10-25
01:14
Version bump check-in: bc031cd63b user: zlodo tags: trunk
01:10
Fix /click requiring to be specified "LeftButton" once again on the PTR (whereas it doesn't want that param at all on the beta right now), jfc blizzard make up your mind it's the other way around every other build (taking the bet that whatever gets pushed to the live servers tomorrow will behave like the PTR right now) check-in: 6c59a1592a user: zlodo tags: trunk
00:28
Merge dragon expansion branch to trunk. check-in: 1925f09269 user: zlodo tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to Smack/macroframe.lua.

63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
    smack.WaitOutOfCombat()

    if self.name then
        self.mainMacroFrame:SetAttribute( "*macrotext-" .. underscoreName )
    end

    self.name = self.macro.name
    self.mainMacroFrame:SetAttribute( "*macrotext-" .. underscoreName, "/click " .. "SmackMacro_" .. self.uid )

    self.frame:Show()
end

function MacroFrame:new( macro, timeslicer )
    local o = {}








|







63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
    smack.WaitOutOfCombat()

    if self.name then
        self.mainMacroFrame:SetAttribute( "*macrotext-" .. underscoreName )
    end

    self.name = self.macro.name
    self.mainMacroFrame:SetAttribute( "*macrotext-" .. underscoreName, "/click " .. "SmackMacro_" .. self.uid .. " LeftButton" )

    self.frame:Show()
end

function MacroFrame:new( macro, timeslicer )
    local o = {}

Changes to Smack_Compiler/frontend/stmt/action.lua.

315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.UseEquippedItem, function( codegen, instr )
    return "m=m..'/use " .. codegen:generateInStrExpr( instr[2] ) .. "\\n'"
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.Click, function( _, instr )
    return "m=m..'/click " .. instr[2]:gsub( "'", "\\'" ) .. "\\n'"
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.CancelAura, function( _, instr )
    return "m=m..'/cancelaura " .. instr[2]:gsub( "'", "\\'" ) .. "\\n'"
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.Target, function( _, instr )







|







315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.UseEquippedItem, function( codegen, instr )
    return "m=m..'/use " .. codegen:generateInStrExpr( instr[2] ) .. "\\n'"
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.Click, function( _, instr )
    return "m=m..'/click " .. instr[2]:gsub( "'", "\\'" ) .. " LeftButton\\n'"
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.CancelAura, function( _, instr )
    return "m=m..'/cancelaura " .. instr[2]:gsub( "'", "\\'" ) .. "\\n'"
end )

compiler.CodeGen:RegisterOpcodeHandler( compiler.CFG.OpCodes.Target, function( _, instr )